fix: sanitize subprocess call in rtl_ltr_linter.py#13194
Open
orbisai0security wants to merge 1 commit intoEbookFoundation:mainfrom
Open
fix: sanitize subprocess call in rtl_ltr_linter.py#13194orbisai0security wants to merge 1 commit intoEbookFoundation:mainfrom
orbisai0security wants to merge 1 commit intoEbookFoundation:mainfrom
Conversation
Automated security fix generated by Orbis Security AI
3 tasks
Contributor
|
I don't think this is valid because |
Author
|
Totally fair point, since we’re passing an argv list and not using shell=True, this isn’t really a shell-injection issue. My patch was aimed more at “defence in depth,” but I agree it’s probably overkill and could reject legit filenames. I’m happy to simplify this to just adding a timeout (and maybe a basic empty/non-string guard) if that’s what you’d prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
scripts/rtl_ltr_linter.py.Vulnerability
V-001scripts/rtl_ltr_linter.py:426Description: The rtl_ltr_linter.py script executes subprocess.check_output at line 426 to run diff commands. If user-controlled input (file paths or command arguments from CLI interfaces at lines 462 and 604) is passed to subprocess without proper sanitization and with shell=True enabled, attackers can inject shell metacharacters to execute arbitrary system commands. This vulnerability allows complete bypass of application logic and direct interaction with the underlying operating system.
Changes
scripts/rtl_ltr_linter.pyVerification
Automated security fix by OrbisAI Security